> On Mar 23, 2021, at 11:31 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote: > > On 3/22/21 9:42 PM, Nilesh Javali wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c >> index c48daf52725d..fa8c4dae8dce 100644 >> --- a/drivers/scsi/qla2xxx/qla_target.c >> +++ b/drivers/scsi/qla2xxx/qla_target.c >> @@ -1029,7 +1029,7 @@ void qlt_free_session_done(struct work_struct *work) >> } >> msleep(100); >> cnt++; >> - if (cnt > 200) >> + if (cnt > 230) >> break; >> } > > One magic constant is changed into another magic constant and that is > sufficient to fix a bug? Please add a comment that explains the meaning > of that constant. > Agree with Bart here. How did you come up with this new count value? Some more details (either in commit message or actual comment in code) would definitely help understand. If you have some log message snippet or stack trace add that to commit message. > Thanks, > > Bart. > -- Himanshu Madhani Oracle Linux Engineering
