On Mon, Mar 22, 2021 at 12:06:36PM -0500, Mike Christie wrote: > > +static u32 rd_get_device_type(struct se_device *dev) > > +{ > > + if (RD_DEV(dev)->rd_flags & RDF_DUMMY) > > + return 0x3f; /* Unknown device type, not connected */ > > + else > > + return TYPE_DISK; > > Maybe have this call sbc_get_device_type here so it matches the other drivers > and how this driver calls into lio core for other operations/fields like > parse_cdb or the attrs. Yeah, good point, I'll fix and send the next round. Are you okay with the whole idea though?