Hi Bart,
> -----Original Message-----
> From: Bart Van Assche <bvanassche@xxxxxxx>
> Sent: Sunday, March 21, 2021 4:54 AM
> To: Martin K . Petersen <martin.petersen@xxxxxxxxxx>; James E . J .
> Bottomley <jejb@xxxxxxxxxxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx; Bart Van Assche <bvanassche@xxxxxxx>;
> Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>; Saurav Kashyap
> <skashyap@xxxxxxxxxxx>; Nilesh Javali <njavali@xxxxxxxxxxx>; Quinn Tran
> <qutran@xxxxxxxxxxx>; Mike Christie <michael.christie@xxxxxxxxxx>;
> Daniel Wagner <dwagner@xxxxxxx>; Lee Duncan <lduncan@xxxxxxxx>
> Subject: [EXT] [PATCH v3 7/7] qla2xxx: Check kzalloc() return value
>
> External Email
>
> ----------------------------------------------------------------------
> Instead of crashing if kzalloc() fails, make qla2x00_get_host_stats()
> return -ENOMEM.
>
> Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host,
> target stats and initiator port")
> Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Cc: Saurav Kashyap <skashyap@xxxxxxxxxxx>
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> Cc: Quinn Tran <qutran@xxxxxxxxxxx>
> Cc: Mike Christie <michael.christie@xxxxxxxxxx>
> Cc: Daniel Wagner <dwagner@xxxxxxx>
> Cc: Lee Duncan <lduncan@xxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index bee8cf9f8123..bc84b2f389f8 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -2583,6 +2583,10 @@ qla2x00_get_host_stats(struct bsg_job *bsg_job)
> }
>
> data = kzalloc(response_len, GFP_KERNEL);
> + if (!data) {
> + kfree(req_data);
> + return -ENOMEM;
> + }
>
> ret = qla2xxx_get_ini_stats(fc_bsg_to_shost(bsg_job), req_data-
> >stat_type,
> data, response_len);
Thanks for the patch.
Acked-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>
