Re: [PATCH] qla2xxx: fix broken #endif placement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Mar 14, 2021, at 10:32 AM, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> 
> Only half of the file is under include guard because terminating #endif
> is placed too early.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
> 
> drivers/scsi/qla2xxx/qla_target.h |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -116,7 +116,6 @@
> 	(min(1270, ((ql) > 0) ? (QLA_TGT_DATASEGS_PER_CMD_24XX + \
> 		QLA_TGT_DATASEGS_PER_CONT_24XX*((ql) - 1)) : 0))
> #endif
> -#endif
> 
> #define GET_TARGET_ID(ha, iocb) ((HAS_EXTENDED_IDS(ha))			\
> 			 ? le16_to_cpu((iocb)->u.isp2x.target.extended)	\
> @@ -244,6 +243,7 @@ struct ctio_to_2xxx {
> #ifndef CTIO_RET_TYPE
> #define CTIO_RET_TYPE	0x17		/* CTIO return entry */
> #define ATIO_TYPE7 0x06 /* Accept target I/O entry for 24xx */
> +#endif
> 
> struct fcp_hdr {
> 	uint8_t  r_ctl;

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux