Thanks for the info. Attached is the patch I feel will address this issue. As an added 'perk' I have also added the code to detect if the controller was previously initialized for interrupted operations by ANY operating system should the reset_devices kernel parameter not be set and we are dealing with a naïve kexec without the addition of this kernel parameter. The reset handler is also improved. Related to reset operations, but not pertinent specifically to this issue, I have also altered the handling somewhat so that we reset the adapter if we feel it is taking too long (three minutes) to start up. We have not unit tested the reset_devices flag propagation to this driver code, nor have we unit tested the check for the interrupted operations under the conditions of a naively issued kexec. We are submitting this modified driver to our Q/A department for integration testing in our current programs. I would appreciate an ACK to this patch should it resolve the issue described in this thread... ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patches. This attached patch is against current scsi-misc-2.6 Signed-off-by: Mark Salyzyn <aacraid@xxxxxxxxxxx> --- Sincerely -- Mark Salyzyn > -----Original Message----- > From: Vivek Goyal [mailto:vgoyal@xxxxxxxxxx] > Sent: Friday, March 30, 2007 2:06 AM > To: Salyzyn, Mark > Cc: Judith Lebzelter; linux-scsi@xxxxxxxxxxxxxxx; AACRAID; > fastboot@xxxxxxxxxxxxxx > Subject: Re: [Fastboot] Panics for AACRAID driver during > 'insmod' for kexec test. > > > On Thu, Mar 29, 2007 at 10:17:18AM -0400, Salyzyn, Mark wrote: > > I have been working on a patch to the driver to do just > this, reset the > > adapter during init if necessary. We want to limit the > adapter's reset > > as it takes time (an additional 45 seconds or longer) for > the Firmware > > to cycle... I will bump the priority of the testing for this patch. > > > Hi, > > Thanks for looking into this. You can make device reset > conditional. Now > one command line parameter "reset_devices" has been defined > for the kernel. > You can reset the device only if the user has passed > reset_devices command > line option otherwise you can continue to boot normaly. > > I have introduced this parameter to handle the concern that in normal > BIOS boot total boot time will increase. > > kexec/kdump will pass this parameter to second kernel so that > device will > be reset during initialization and normal BIOS boot will > reamin unaffected. > > Thanks > Vivek >
Attachment:
aacraid_kexec.patch
Description: aacraid_kexec.patch