On Fri, Mar 30 2007, FUJITA Tomonori wrote: > From: Jens Axboe <jens.axboe@xxxxxxxxxx> > Subject: Re: [PATCH] bsg: minor bug fixes > Date: Fri, 30 Mar 2007 08:38:04 +0200 > > > On Fri, Mar 30 2007, FUJITA Tomonori wrote: > > > This fixes the following minor issues: > > > > > > - When bsg_register_queue is called with a request queue that doesn't > > > have request_fn, it returns -EINVAL instead of zero. > > > > Seems a little backwards, you wont be able to talk to the device then. > > What do you mean? All the devices that we might bind to bsg has > request_fn? They have to, how else would you send commands to it? > > So, what is the purpose of this patch? > > When I wrote a SMP pass through interface via bsg, I thought that it > would be better to return an error instead of success when we call > bsg_register_queue with a request queue that doesn't have a > request_fn. > > > Anyway, it doesn't matter much. Here is a new version. Aplied this one. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
