On Tue, 2021-03-02 at 10:14 +0200, Adrian Hunter wrote: > > > That can result in the state being UFSHCD_STATE_ERROR even though > > > ufshcd_reset_and_restore() is successful and returns zero. > > > > > > Fix by initializing the state to UFSHCD_STATE_RESET in the start > > > of each > > > loop in ufshcd_reset_and_restore(). If there is an error, > > > ufshcd_reset_and_restore() will change the state to > > > UFSHCD_STATE_ERROR, > > > otherwise ufshcd_probe_hba() will have set the state > > > appropriately. > > > > > > Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler > > > and other > > > error recovery paths") > > > Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> > > > > I think that CanG recent series addressed that issue as well, can > > you take a look? > > https://lore.kernel.org/lkml/1614145010-36079-2-git-send-email-cang@xxxxxxxxxxxxxx/ > > Yes, there it is mixed in with other changes. However it is probably > better > as a separate patch. Can Guo, what do you think? we can firstly take this fixup patch.