On 08:56 Mon 01 Mar 2021, Randy Dunlap wrote:
On 3/1/21 5:17 AM, Bhaskar Chowdhury wrote:s/circuting/circuiting/ Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> However: In lots of your patches, the subject begins with drivers: and we don't need that. See the SCSI qla4xxx driver patches, e.g.:
Thanks, Randy....took note...about this ...will practice...
$ git log --oneline drivers/scsi/qla4xxx/ 5b0ec4cf0494 scsi: qla4xxx: Use iscsi_is_session_online() 35f1cad1f928 scsi: qla4xxx: Use standard SAM status definitions 3a5b9fa2cc5f scsi: qla4xxx: Remove redundant assignment to variable rval 014aced18aff scsi: qla4xxx: Remove in_interrupt() from qla4_82xx_rom_lock() 3627668c2e2c scsi: qla4xxx: Remove in_interrupt() from qla4_82xx_idc_lock() a93c38353198 scsi: qla4xxx: Remove in_interrupt() cf4d4d8ebdb8 scsi: qla4xxx: Remove redundant assignment to variable rval 5ccdd101351d scsi: qla4xxx: Fix inconsistent format argument type 121432e87093 scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed e3976af5a475 scsi/qla4xxx: Convert to SPDX license identifiers 574918e69720 scsi: qla4xxx: Fix an error handling path in 'qla4xxx_get_host_stats()' d10d1df6301d scsi: qla4xxx: Rename function parameter descriptions 6e3f4f68821b scsi: qla4xxx: Remove set but unused variable 'status' 653557df36e0 scsi: qla4xxx: Supply description for 'code' f67e81641db7 scsi: qla4xxx: Remove three set but unused variables c0ad04b4b6d7 scsi: qla4xxx: Document qla4xxx_process_ddb()'s 'conn_err' fc5fba6e2ae2 scsi: qla4xxx: Repair function documentation headers cdeeb36d8f24 scsi: qla4xxx: Fix some kerneldoc parameter documentation issues 67b8b93a559f scsi: qla4xxx: Fix incorrectly named function parameter 0d5fea42989e scsi: qla4xxx: Fix-up incorrectly documented parameter--- drivers/scsi/qla4xxx/ql4_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index a4b014e1cd8c..716a5827588c 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -6961,7 +6961,7 @@ static int qla4xxx_sess_conn_setup(struct scsi_qla_host *ha, if (is_reset == RESET_ADAPTER) { iscsi_block_session(cls_sess); /* Use the relogin path to discover new devices - * by short-circuting the logic of setting + * by short-circuiting the logic of setting * timer to relogin - instead set the flags * to initiate login right away. */ ---- ~Randy
Attachment:
signature.asc
Description: PGP signature
