Re: [PATCH 2/2][v3] ibmvscsi: add slave_configure to allow device restart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 29 Mar 2007 12:30:40 -0500 Robert Jennings wrote:

> Fixed the kernel-doc comment for ibmvscsi_slave_configure.  Thanks to
> Randy Dunlap for pointing this out.
> 
> Adding a slave_configure function for the driver. Now the disks can be
> restarted by the scsi mid-layer when the are disconnected and reconnected.
> 
> Signed-off-by: "Robert Jennings" <rcj@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: "Santiago Leon" <santil@xxxxxxxxxx>

Looks good, thanks.

> ---
>  drivers/scsi/ibmvscsi/ibmvscsi.c |   22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> Index: b/drivers/scsi/ibmvscsi/ibmvscsi.c
> ===================================================================
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -1354,6 +1354,27 @@
>  	return rc;
>  }
>  
> +/**
> + * ibmvscsi_slave_configure: Set the "allow_restart" flag for each disk.
> + * @sdev:	struct scsi_device device to configure
> + *
> + * Enable allow_restart for a device if it is a disk.  Adjust the
> + * queue_depth here also as is required by the documentation for
> + * struct scsi_host_template.
> + */
> +static int ibmvscsi_slave_configure(struct scsi_device *sdev)
> +{
> +	struct Scsi_Host *shost = sdev->host;
> +	unsigned long lock_flags = 0;
> +
> +	spin_lock_irqsave(shost->host_lock, lock_flags);
> +	if (sdev->type == TYPE_DISK)
> +		sdev->allow_restart = 1;
> +	scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
> +	spin_unlock_irqrestore(shost->host_lock, lock_flags);
> +	return 0;
> +}
> +
>  /* ------------------------------------------------------------
>   * sysfs attributes
>   */


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux