Hi Xiaofei, On Sun, Feb 7, 2021 at 12:46 PM Xiaofei Tan <tanxiaofei@xxxxxxxxxx> wrote: > Replace spin_lock_irqsave with spin_lock in hard IRQ of SCSI drivers. > There are no function changes, but may speed up if interrupt happen > too often. I'll bite: how much does this speed up interrupt processing? What's the typical cost of saving/disabling, and restoring interrupt state? Is removing this cost worth the risk of introducing subtle regressions on platforms you cannot test yourself? BTW, how many of these legacy SCSI controllers do you have access to? Thanks for your answers! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds