On 12/22/20 11:11 AM, Kashyap Desai wrote: > Signed-off-by: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx> > Cc: sathya.prakash@xxxxxxxxxxxx > --- > drivers/scsi/mpi3mr/mpi3mr.h | 18 +- > drivers/scsi/mpi3mr/mpi3mr_fw.c | 7 + > drivers/scsi/mpi3mr/mpi3mr_os.c | 303 +++++++++++++++++++++++++++++++- > 3 files changed, 321 insertions(+), 7 deletions(-) > > diff --git a/drivers/scsi/mpi3mr/mpi3mr.h b/drivers/scsi/mpi3mr/mpi3mr.h > index f0ead83dc16c..acc5649bed5f 100644 > --- a/drivers/scsi/mpi3mr/mpi3mr.h > +++ b/drivers/scsi/mpi3mr/mpi3mr.h > @@ -118,6 +118,7 @@ extern struct list_head mrioc_list; > #define MPI3MR_SENSEBUF_SZ 256 > #define MPI3MR_SENSEBUF_FACTOR 3 > #define MPI3MR_CHAINBUF_FACTOR 3 > +#define MPI3MR_CHAINBUFDIX_FACTOR 2 > > /* Invalid target device handle */ > #define MPI3MR_INVALID_DEV_HANDLE 0xFFFF > @@ -145,6 +146,15 @@ extern struct list_head mrioc_list; > /* Default target device queue depth */ > #define MPI3MR_DEFAULT_SDEV_QD 32 > > +/* Definitions for the sector size for EEDP */ > +#define MPI3_SECTOR_SIZE_512_BYTE (512) > +#define MPI3_SECTOR_SIZE_520_BYTE (520) > +#define MPI3_SECTOR_SIZE_4080_BYTE (4080) > +#define MPI3_SECTOR_SIZE_4088_BYTE (4088) > +#define MPI3_SECTOR_SIZE_4096_BYTE (4096) > +#define MPI3_SECTOR_SIZE_4104_BYTE (4104) > +#define MPI3_SECTOR_SIZE_4160_BYTE (4160) > + This looks weird, please use the values directly instead of creating macros. tomash