> - ret = scsi_execute_req(sdev, cdb, > - send ? DMA_TO_DEVICE : DMA_FROM_DEVICE, > - buffer, len, NULL, SD_TIMEOUT, sdkp->max_retries, NULL); > + ret = scsi_execute(sdev, cdb, > + send ? DMA_TO_DEVICE : DMA_FROM_DEVICE, buffer, len, > + /*sense=*/NULL, /*sshdr=*/NULL, SD_TIMEOUT, sdkp->max_retries, > + /*flags=*/0, /*rq_flags=*/RQF_PM, /*resid=*/NULL); Please keep the existing style here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>