Re: [PATCH] scsi/sd: Fix Opal support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -	ret = scsi_execute_req(sdev, cdb,
> -			send ? DMA_TO_DEVICE : DMA_FROM_DEVICE,
> -			buffer, len, NULL, SD_TIMEOUT, sdkp->max_retries, NULL);
> +	ret = scsi_execute(sdev, cdb,
> +		send ? DMA_TO_DEVICE : DMA_FROM_DEVICE, buffer, len,
> +		/*sense=*/NULL, /*sshdr=*/NULL, SD_TIMEOUT, sdkp->max_retries,
> +		/*flags=*/0, /*rq_flags=*/RQF_PM, /*resid=*/NULL);

Please keep the existing style here.  Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux