RE: [PATCH V3] iscsi: Do Not set param when sock is NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

        Regarding " Also there might be the case where a tool sets a value then forces a relogin and the new value would get used for some drivers." in your below mail, I was trying to understand this. Can you please give me an example? It will help me to understand clearly.

Regards,
Gulam Mohamed.

-----Original Message-----
From: Michael Christie <michael.christie@xxxxxxxxxx> 
Sent: Wednesday, February 3, 2021 7:47 AM
To: Gulam Mohamed <gulam.mohamed@xxxxxxxxxx>; lduncan@xxxxxxxx; cleech@xxxxxxxxxx; Martin Petersen <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx
Subject: Re: [PATCH V3] iscsi: Do Not set param when sock is NULL

On 1/28/21 12:17 AM, Gulam Mohamed wrote:
> Description
> ===========
> 1. This Kernel panic could be due to a timing issue when there is a race
>    between the sync thread and the initiator was processing of a login 
> r

Hey,

Sorry. When I had said that we want to limit the width, I didn't mean that it should split words like above.

>  	default:
> +		if (conn->state != ISCSI_CONN_BOUND)
> +			return -ENOTCONN;

How about making this a check for BOUND or UP? Some of the settings, like the TMF related ones, can be set after the conn is connected. open-iscsi doesn't support it, but maybe other tools do. Also there might be the case where a tool sets a value then forces a relogin and the new value would get used for some drivers.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux