On 17/02/2021 12:17, Dan Carpenter wrote: > On Wed, Feb 17, 2021 at 09:18:37AM +0000, Johannes Thumshirn wrote: >> * @flags: gfp mask for the allocation - must be compatible (superset) with GFP_KERNEL. >> >> So yeah, we should've read that before calling kvcalloc(..., GFP_NOIO). > > This is a Smatch check now and checks are better than comments. :) Definitively