Hi Mike, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on vhost/linux-next v5.11-rc7 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: h8300-randconfig-s031-20210209 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-215-g0fb77bb6-dirty # https://github.com/0day-ci/linux/commit/b5a5f1dde145805b1ea13be05f6a28386284ac2e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926 git checkout b5a5f1dde145805b1ea13be05f6a28386284ac2e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/target/loopback/tcm_loop.c: In function 'tcm_loop_queuecommand': >> drivers/target/loopback/tcm_loop.c:188:23: warning: variable 'tl_tpg' set but not used [-Wunused-but-set-variable] 188 | struct tcm_loop_tpg *tl_tpg; | ^~~~~~ vim +/tl_tpg +188 drivers/target/loopback/tcm_loop.c 179 180 /* 181 * ->queuecommand can be and usually is called from interrupt context, so 182 * defer the actual submission to a workqueue. 183 */ 184 static int tcm_loop_queuecommand(struct Scsi_Host *sh, struct scsi_cmnd *sc) 185 { 186 struct tcm_loop_cmd *tl_cmd = scsi_cmd_priv(sc); 187 struct tcm_loop_hba *tl_hba; > 188 struct tcm_loop_tpg *tl_tpg; 189 190 tl_hba = *(struct tcm_loop_hba **)shost_priv(sc->device->host); 191 tl_tpg = &tl_hba->tl_hba_tpgs[sc->device->id]; 192 193 pr_debug("%s() %d:%d:%d:%llu got CDB: 0x%02x scsi_buf_len: %u\n", 194 __func__, sc->device->host->host_no, sc->device->id, 195 sc->device->channel, sc->device->lun, sc->cmnd[0], 196 scsi_bufflen(sc)); 197 198 memset(tl_cmd, 0, sizeof(*tl_cmd)); 199 tl_cmd->sc = sc; 200 tl_cmd->sc_cmd_tag = sc->request->tag; 201 202 tcm_loop_target_queue_cmd(tl_cmd); 203 return 0; 204 } 205 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
