On 2/4/21 10:09 PM, Can Guo wrote: > That code is wrong. The Task Tag in Dword_0 should be the real tag we > allocated for TMR. The transfer request Task Tag which we are trying to > abort is given in Dword_5, which is the Input Parameter 3 of the TMR UPIU. > I am not sure why the author gave hba->nutrs + req->tag as the Task Tag > of one TMR, the commit msg abot this part is not quite informative.... > > Table 10.22 — Task Management Request UPIU > TASK MANAGEMENT REQUEST UPIU > ---------------------------------- > |0 |1 |2 |3 | > ---------------------------------- > |xx00 0100b| Flags |LUN |Task Tag| > ---------------------------------- > ... > 16 (MSB) |17 |18 |19 (LSB)| > ---------------------------------- > Input Parameter 2 > ---------------------------------- > > Table 10.24 — Task Management Input Parameters > Field Description > Input Parameter 2 LSB: Task Tag of the task/command operated by the task > management function. Thanks for the clarification. Feel free to add the following to this patch: Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
