> On Jan 26, 2021, at 2:42 AM, Jiapeng Zhong <abaci-bugfix@xxxxxxxxxxxxxxxxx> wrote: > > Fix the following coccicheck warnings: > > ./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is > equivalent to !A || B. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@xxxxxxxxxxxxxxxxx> > --- > drivers/scsi/qla2xxx/qla_nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c > index eab559b..38196b2 100644 > --- a/drivers/scsi/qla2xxx/qla_nvme.c > +++ b/drivers/scsi/qla2xxx/qla_nvme.c > @@ -285,7 +285,7 @@ static int qla_nvme_ls_req(struct nvme_fc_local_port *lport, > srb_t *sp; > > > - if (!fcport || (fcport && fcport->deleted)) > + if (!fcport || fcport->deleted) > return rval; > > vha = fcport->vha; > -- > 1.8.3.1 > Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> -- Himanshu Madhani Oracle Linux Engineering