On Tue, 20 Mar 2007, James Bottomley wrote: > On Tue, 2007-03-20 at 11:56 -0700, Andrew Vasquez wrote: > > Commit 840c2835a1c867281d27158378a9d34f593a7664 ([SCSI] make > > scsi_wait_scan always modular) broke configurations where > > SCSI_SCAN_ASYNC is selected for non-modular builds. > > > > Signed-off-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx> > > --- > > > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > > index f3bc0f4..eb25abe 100644 > > --- a/drivers/scsi/Kconfig > > +++ b/drivers/scsi/Kconfig > > @@ -226,6 +226,7 @@ config SCSI_LOGGING > > config SCSI_SCAN_ASYNC > > bool "Asynchronous SCSI scanning" > > depends on SCSI > > + select SCSI_WAIT_SCAN > > This can't really be right. Async scan is always compiled in, so the > module is always required ... this parameter just determines what the > boot time default is, but it can be overridden by the kernel command > line. > > What's the actual problem you're trying to fix? SCSI_SCAN_ASYNC was compiled non-modularly before merging the latest scsi-misc-2.6.git tree. After the merge, and a rebuild of the kernel, was getting 'unknown symbol' failures during link as SCSI_WAIT_SCAN was now forced to be built as a module. 'select'ion of SCSI_WAIT_SCAN based on SCSI_SCAN_SYNC (a consumer) appeared to be the most natural way to address the problem. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
