From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> Subject: Re: [PATCH] bind bsg to request_queue instead of gendisk Date: Mon, 19 Mar 2007 19:25:34 +0900 > From: Jens Axboe <jens.axboe@xxxxxxxxxx> > Subject: Re: [PATCH] bind bsg to request_queue instead of gendisk > Date: Wed, 14 Feb 2007 22:25:00 +0100 > > > On Wed, Feb 14 2007, FUJITA Tomonori wrote: > > > It seems that it would be better to bind bsg devices to request_queue > > > instead of gendisk. This enables any objects to define own > > > request_handler and create own bsg device (under sysfs). > > > > > > Possible enhancements: > > > > > > - I removed gendisk but it would be better for objects having gendisk > > > to keep it for nice features like disk stats. > > > > > > - Objects that wants to use bsg need to setup a request_queue. Maybe > > > wrapper functions to setup a request_queue for them would be useful. > > > > > > This patch was tested only with disk drivers. > > > > Looks good, as discussed in-person I just want to change the _rq name as > > that usually implies "struct request" in the block layer. _queue is much > > better. > > Here is a resend though including the following updates. > > - bsg_register/unregister_rq are renamed bsg_register/unregister_queue > > - fix !CONFIG_BLK_DEV_BSG compilation > > --- > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > This binds bsg devices to request_queue instead of gendisk. It enables > any objects (like transport entities) to define own request_handler > and create own bsg device. > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> Sorry, this patch doesn't work. I'll resend an updated patch later. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
