On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: > + err = pci_enable_device(pdev); > + if (err < 0) > + return err; Traditionally, this should be if (err) return err; The reason is that <0 is a signed comparison which can be slightly more expensive on some architectures and it's unnecessary if zero is the only successful return. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
