On Tue, Jan 12, 2021 at 11:36:21AM +0000, John Garry wrote: > On 12/01/2021 11:06, Ahmed S. Darwish wrote: > > From: John Garry<john.garry@xxxxxxxxxx> > > > > The LLDDs report events to libsas with .notify_port_event and > > .notify_phy_event callbacks. > > > > These callbacks are fixed and so there is no reason why we cannot call the > > functions directly, so do that. > > > > This neatens the code slightly. > > > > [a.darwish@xxxxxxxxxxxxx: Remove the now unused "sas_ha" local variables] > > Signed-off-by: John Garry<john.garry@xxxxxxxxxx> > > Don't forget your signed-off-by :) > Oh, yes. > > > > diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst > > index f9b77c7879db..a183b1d84713 100644 > > --- a/Documentation/scsi/libsas.rst > > +++ b/Documentation/scsi/libsas.rst > > @@ -189,8 +189,8 @@ num_phys > > The event interface:: > > /* LLDD calls these to notify the class of an event. */ > > - void (*notify_port_event)(struct sas_phy *, enum port_event); > > - void (*notify_phy_event)(struct sas_phy *, enum phy_event); > > + void sas_notify_port_event(struct sas_phy *, enum port_event); > > + void sas_notify_phy_event(struct sas_phy *, enum phy_event); > > When sas_register_ha() returns, those are set and can be > > called by the LLDD to notify the SAS layer of such events > > Maybe this was missed in the rebase, but I think that this comment can go/be > changed at some stage. > Yeah, I pulled the patch yesterday from: https://github.com/hisilicon/kernel-dev/commit/87fcd7e113dc05b7933260e7fa4588dc3730cc2a Lemme check if there are any other differences. Thanks, -- Ahmed S. Darwish
