Hi John, On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote: > LLDDs report events to libsas with .notify_port_event and > .notify_phy_event callbacks. > > These callbacks are fixed and so there is no reason why the functions > cannot be called directly, so do that. > > This neatens the code slightly, makes it more obvious, and reduces > function pointer usage, which is generally a good thing. Downside is that > there are 2x more symbol exports. > > Signed-off-by: John Garry <john.garry@xxxxxxxxxx> > Since this patch necessitates a careful manual rebase of _every_ patch in my series, I've included it at the top of my v2 submission and rebased everything on top: https://lkml.kernel.org/r/20210112110647.627783-1-a.darwish@xxxxxxxxxxxxx Some left-over 'sas_ha' local variables were removed, and I've mentioned that in the commit log of course. Thanks! -- Ahmed S. Darwish Linutronix GmbH