RE: [PATCH V3 07/25] smartpqi: update AIO Sub Page 0x02 support

[<Don.Brace@xxxxxxxxxxxxx>]

-----Original Message-----
From: Martin Wilck [mailto:mwilck@xxxxxxxx] 
Subject: Re: [PATCH V3 07/25] smartpqi: update AIO Sub Page 0x02 support

On Thu, 2020-12-10 at 14:35 -0600, Don Brace wrote:
> From: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx>
>
> The specification for AIO Sub-Page (0x02) has changed slightly.
> * bring the driver into conformance with the spec.
>
>
> +static inline u32 pqi_aio_limit_to_bytes(__le16 *limit) {
> +       u32 bytes;
> +
> +       bytes = get_unaligned_le16(limit);
> +       if (bytes == 0)
> +               bytes = ~0;
> +       else
> +               bytes *= 1024;
> +
> +       return bytes;
> +}

Nice, but this function and it's callers belong into patch 06/25.

Don: 
      * Squashed smartpqi-update-AIO-Sub-Page-0x02-support
      * Moved formatting HUNK for pqi_scsi_dev_raid_map_data into
        smartpqi-refactor-aio-submission-code
      * Moved structure pqi_aio_r56_path_request formatting HUNKS into
        smartpqi-add-support-for-raid5-and-raid6-writes
      * Moved remaining formatting HUNKs into
        smartpqi-align-code-with-oob-driver

Thanks for all of your attention to detail,
Don

> +
>  #pragma pack(1)
>
>
>  static int pqi_get_advanced_raid_bypass_config(struct pqi_ctrl_info
> *ctrl_info)
> @@ -753,33 +766,28 @@ static int
> pqi_get_advanced_raid_bypass_config(struct pqi_ctrl_info *ctrl_info)
>                         BMIC_SENSE_FEATURE_IO_PAGE_AIO_SUBPAGE ||
>                 get_unaligned_le16(&buffer-
> >aio_subpage.header.page_length) <
>                         MINIMUM_AIO_SUBPAGE_LENGTH) {
> -               rc = -EINVAL;

This should be changed in 06/25.

>                 goto error;
>         }
>

Regards
Martin