Hi, Thanks for a patch. > -----Original Message----- > From: YANG LI <abaci-bugfix@xxxxxxxxxxxxxxxxx> > Sent: Monday, January 11, 2021 2:59 PM > To: jejb@xxxxxxxxxxxxx > Cc: martin.petersen@xxxxxxxxxx; Saurav Kashyap <skashyap@xxxxxxxxxxx>; > Javed Hasan <jhasan@xxxxxxxxxxx>; GR-QLogic-Storage-Upstream <GR- > QLogic-Storage-Upstream@xxxxxxxxxxx>; linux@xxxxxxxxxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > YANG LI <abaci-bugfix@xxxxxxxxxxxxxxxxx> > Subject: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison > > External Email > > ---------------------------------------------------------------------- > Fix the following coccicheck warning: > ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool > > Signed-off-by: YANG LI <abaci-bugfix@xxxxxxxxxxxxxxxxx> > Reported-by: Abaci Robot<abaci@xxxxxxxxxxxxxxxxx> > --- > drivers/scsi/qedf/qedf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c > index 46d185c..cec27f2 100644 > --- a/drivers/scsi/qedf/qedf_main.c > +++ b/drivers/scsi/qedf/qedf_main.c > @@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int > mode) > else > fc_fabric_logoff(qedf->lport); > > - if (qedf_wait_for_upload(qedf) == false) > + if (!qedf_wait_for_upload(qedf)) > QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n"); > > #ifdef CONFIG_DEBUG_FS > -- > 1.8.3.1 Acked-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>
