Subject: Re: [PATCH V3 05/25] smartpqi: add support for raid1 writes
> @@ static bool pqi_aio_raid_level_supported(struct pqi_ctrl_info
> *ctrl_info,
> case SA_RAID_0:
> break;
> case SA_RAID_1:
> - is_supported = false;
> + fallthrough;
Nit: fallthrough isn't necessary here.
Don: removed fallthrough
>
> +static int pqi_aio_submit_r1_write_io(struct pqi_ctrl_info
> *ctrl_info,
> + struct scsi_cmnd *scmd, struct pqi_queue_group *queue_group,
> + struct pqi_encryption_info *encryption_info, struct
> pqi_scsi_dev *device,
> + struct pqi_scsi_dev_raid_map_data *rmd)
> +
> + switch (scmd->sc_data_direction) {
> + case DMA_TO_DEVICE:
> + r1_request->data_direction = SOP_READ_FLAG;
> + break;
Same question as for previous patch, how would anything else than DMA_TO_DEVICE be possible here?
Don: changed direction to write, added comment.
Thank-you Martin for your review. I'll upload a V4 after I complete the other reviews.
Don Brace
