On Thu, 2020-12-10 at 14:36 -0600, Don Brace wrote:
> From: Murthy Bhat <Murthy.Bhat@xxxxxxxxxxxxx>
>
> * Update enclosure identifier field corresponding to
> physical devices in lsscsi/sysfs.
>
> Reviewed-by: Scott Benesh <scott.benesh@xxxxxxxxxxxxx>
> Reviewed-by: Scott Teel <scott.teel@xxxxxxxxxxxxx>
> Reviewed-by: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx>
> Signed-off-by: Murthy Bhat <Murthy.Bhat@xxxxxxxxxxxxx>
> Signed-off-by: Don Brace <don.brace@xxxxxxxxxxxxx>
> ---
> drivers/scsi/smartpqi/smartpqi_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
> b/drivers/scsi/smartpqi/smartpqi_init.c
> index 1c51a59f1da6..40ae82470d8c 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -1841,7 +1841,6 @@ static void pqi_dev_info(struct pqi_ctrl_info
> *ctrl_info,
> static void pqi_scsi_update_device(struct pqi_scsi_dev
> *existing_device,
> struct pqi_scsi_dev *new_device)
> {
> - existing_device->devtype = new_device->devtype;
> existing_device->device_type = new_device->device_type;
> existing_device->bus = new_device->bus;
> if (new_device->target_lun_valid) {
>
I don't get this. Why was it wrong to update the devtype field?
