On Thu, 2020-12-10 at 14:34 -0600, Don Brace wrote: > From: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx> > > Reviewed-by: Scott Benesh <scott.benesh@xxxxxxxxxxxxx> > Reviewed-by: Scott Teel <scott.teel@xxxxxxxxxxxxx> > Signed-off-by: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx> > Signed-off-by: Don Brace <don.brace@xxxxxxxxxxxxx> > --- > drivers/scsi/smartpqi/smartpqi.h | 11 ++++++++++- > drivers/scsi/smartpqi/smartpqi_init.c | 11 +++++++++-- > drivers/scsi/smartpqi/smartpqi_sis.c | 5 +++++ > drivers/scsi/smartpqi/smartpqi_sis.h | 1 + > 4 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/smartpqi/smartpqi.h > b/drivers/scsi/smartpqi/smartpqi.h > index 3e54590e6e92..7d3f956e949f 100644 > > [...] > > --- a/drivers/scsi/smartpqi/smartpqi_init.c > +++ b/drivers/scsi/smartpqi/smartpqi_init.c > @@ -6259,8 +6259,8 @@ static DEVICE_ATTR(model, 0444, pqi_model_show, > NULL); > static DEVICE_ATTR(serial_number, 0444, pqi_serial_number_show, > NULL); > static DEVICE_ATTR(vendor, 0444, pqi_vendor_show, NULL); > static DEVICE_ATTR(rescan, 0200, NULL, pqi_host_rescan_store); > -static DEVICE_ATTR(lockup_action, 0644, > - pqi_lockup_action_show, pqi_lockup_action_store); > +static DEVICE_ATTR(lockup_action, 0644, pqi_lockup_action_show, > + pqi_lockup_action_store); Nitpick: could you please avoid mixing real code changes with unrelated whitespace edits? The same applies to several patches of this series. Other than that: Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
