This patch set is a request to incorporate the new Broadcom
(Emulex) FC target driver, efct, into the kernel source tree.
The driver source has been Announced a couple of times, the last
version on 1/03/2021. The driver has been hosted on gitlab for
review has had contributions from the community.
gitlab (git@xxxxxxxxxx:jsmart/efct-Emulex_FC_Target.git)
The driver integrates into the source tree at the (new) drivers/scsi/elx
subdirectory.
The driver consists of the following components:
- A libefc_sli subdirectory: This subdirectory contains a library that
encapsulates common definitions and routines for an Emulex SLI-4
adapter.
- A libefc subdirectory: This subdirectory contains a library of
common routines. Of major import is a number of routines that
implement a FC Discovery engine for target mode.
- An efct subdirectory: This subdirectory contains the efct target
mode device driver. The driver utilizes the above librarys and
plugs into the SCSI LIO interfaces. The driver is SCSI only at
this time.
The patches populate the libraries and device driver and can only
be compiled as a complete set.
This driver is completely independent from the lpfc device driver
and there is no overlap on PCI ID's.
The patches have been cut against the 5.11/scsi-queue branch.
Thank you to those that have contributed to the driver in the past.
Review comments welcome!
-- james
Note: cpu offline/online support will be added at a later time
V6 modifications:
Refactor for better indentation and reduced else's
Refactor to use structure elements directly and avoid local vars
Slight update to node_sm_trace macro
convert efc_nport_cb() to not return a value
moved libefc/efc_lib.c to libefc/efclib.c
Reword comment in efc_node_handle_explicit_logo()
efc_disc_io_complete(): update WARN_ON to WARN_ON_ONCE
Change els send functions to return status from efc_els_send_req()
Ensure an EFC_XXX status value is returned (not numerical constants)
Dynamically allocate wq_cpu_array rather than fixed size array
Fix return variables to have same type as routine
Ensure an EFCT_HW_XXX status value is returned (not numerical constants)
Kernel doc format changes for efct_io structure.
Cleanup of meaningless comments in efct_scsi_cmd_resp declaration
in hw rtns: Replace EFC_FAIL status with EFCT_HW_XXX status values
add kfree to efct_hw_teardown()
V5 modifications:
Copyright for 2021 year change.
Fixed kernel test robot reported warnings.
Changed BMBX_WRITE defines to static inline functions.
Common naming for topology defines.
Remove efc_log_test.
Topology naming changes.
Indentation change.
Changed argument list for sli_cmd_reg_fcfi/ sli_cmd_reg_fcfi_mrq
Added Mempool for ELS ios.
Remove EFC_HW_NODE_XXX and EFC_HW_NPORT_XXX events.
Use EFC_EVT_XXX events directly for port and node callbacks.
Remove node_list from nport and use xarray lookup.
Use WRITE_ONCE/READ_ONCE for els_io_enabled flag.
Replace nport_list with xarray lookup related changes.
Topology naming changes.
ELS IO mempool changes.
EFC_EVT_XXX name changes.
Replace global efct_devices array with linked list.
Add support for FC speed 64G and 128G
Use list_del_int() when needed.
V4 modifications:
Copyright year change.
Fixed cppcheck tool reported warnings.
Ran pahole tool, fixed padding for most of the structures.
Support for Multiple RQs and EQs.
New user driver node structure to avoid lock contension in IO path.
libefc_sli:
Add target-devel@xxxxxxxxxxxxxxx in MAINTAINERS
Changed doorbell defines to inline functions
Code cleanup: Indentation, code simplification, unnecessary brackets
Added SLI4_ prefix to missing defines
Moved driver specific structures to the end of the file.
Page size calculation changes
Reduce function parameters for WQE filling functions
Changed wait functions to use usleep_range and time_before apis
Removed size input for all the cmds as its fixed to SLI4_BMBX_SIZE.
Changed all SLI mbox routines to memset using SLI_BMBX_SIZE.
All WQE helper routines to use sli->wqe_size for memset.
libefc:
Remove the " EFC_SM_EVENT_START" id and define SM events serially.
Moved hold frames and pending frames handling to library.
Added efc locking notes.
Added kref to domain, nport and node objects.
Renamed efc_sli_port object to efc_nport
Reworked on APIs and libefc_function_template.
Moved ELS handling to Library
Moved registering discovery objects to library.
Added issue_mbox_rqst, send_els, send_bls template functions.
Changes to use new function template
Get Domain Ref count when a new nport is added
Release domain ref when nport is freed.
Renamed efc_sport.[ch] to efc_nport.[ch]
Add kref support for Nport structure.
Upon received PRLI, wait for LIO session registation before sending
the PRLI response.
Changes to call new els functions.
Move all state machine functions return value from void * to void.
Replace fall through commnet with fallthrough statement.
New patch added ELS handling to libefc library.
New els_io_req for discovery io object.
New patch cmds to register VFI, VPI and RPI.
Removed all hw related template calls and added issue_mbox_rqst
template call.
Consolidate all the discovery related mbox related cmds in discovery
library.
Replaced allocation of command buffer for mailbox with stack variable.
efct driver:
New library Template registration and associated functions
Muti-RQ support, configure mrq.
Configure filter to send all ELS traffic to one RQ and remaining IOs
to all RQs.
CPU based WQ scaling.
Allocate loop map during initialization
Remove redundant includes in efc_driver.h
Remove els entries from scsi io object as discovery object handles it.
Changed unsol frame handling.
Lookup for efct target node based on d_id and s_id.
Rework IO path to not look up discovery object every time.
Changes to reduce function params for efct_hw_io_send
Changes to create efct_node(user driver specific node) and store
lookup id.
Removed debugfs interface.
Reduced the argument list for WQE filling routines.
V3 modifications:
Changed anonymous enums to named enums
Split gaint enums into multiple enums
Use defines to spell out _MASK values directly
Changed multiple #defines to named enums and a few vice versa cases
for consistency
Added Link Speed support for up to 128G
Removed efc_assert define. Replaced with WARN_ON.
Returned defined return values EFC_SUCCESS & EFC_FAIL
Added return values for routines returning more than those 2 values
Reduction of calling arguments in various routines.
Expanded dump type and status handling
Fixed locking in discovery handling routines.
Fixed line formatting length and indentation issues.
Removed code that was not used.
Removed Sparse Vector APIs and structures. Use xarray api instead.
Changed node pool creation. Use mempool and allocate dma memory when
required
Bug Fix: Send LS_RJT for non FCP PRLIs
Removed Queue topology string and parsing routines and rework queue
creation. Adapter configuration is implicitly known by the driver
Used request_threaded_irq instead of using our thread
Reworked efct_device_attach function to use if statements and gotos
Changed efct_fw_reset, removed accessing other port
Convert to used pci_alloc_irq_vectors api
Removed proc interface.
Changed assertion log messages.
Unified log message using cmd_name
Removed DIF related code which is not used
Removed SCSI get property
Incorporated LIO interface review comments
Reworked xxx_reg_vpi/vfi routines
Use SPDX license in elx/Makefile
Many more small changes.
V2 modifications:
Contains the following modifications based on prior review comments:
Indentation/Alignment/Spacing changes
Comments: format cleanup; removed obvious or unnecessary comments;
Added comments for clarity.
Headers use #ifndef comparing for prior inclusion
Cleanup structure names (remove _s suffix)
Encapsulate use of macro arguments
Refactor to remove static function declarations for static local routines
Removed unused variables
Fix SLI4_INTF_VALID_MASK for 32bits
Ensure no BIT() use
Use __ffs() in page count macro
Reorg to move field defines out of structure definition
Commonize command building routines to reduce duplication
LIO interface:
Removed scsi initiator includes
Cleaned up interface defines
Removed lio WWN version attribute.
Expanded macros within logging macros
Cleaned up lio state setting macro
Remove __force use
Modularized session debugfs code so can be easily replaced.
Cleaned up abort task handling. Return after initiating.
Modularized where possible to reduce duplication
Convert from kthread to workqueue use
Remove unused macros
Add missing TARGET_CORE build attribute
Fix kbuild test robot warnings
Comments not addressed:
Use of __packed: not believed necessary
Session debugfs code remains. There is not yet a common lio
mechanism to replace with.
James Smart (31):
elx: libefc_sli: SLI-4 register offsets and field definitions
elx: libefc_sli: SLI Descriptors and Queue entries
elx: libefc_sli: Data structures and defines for mbox commands
elx: libefc_sli: queue create/destroy/parse routines
elx: libefc_sli: Populate and post different WQEs
elx: libefc_sli: bmbx routines and SLI config commands
elx: libefc_sli: APIs to setup SLI library
elx: libefc: Generic state machine framework
elx: libefc: Emulex FC discovery library APIs and definitions
elx: libefc: FC Domain state machine interfaces
elx: libefc: SLI and FC PORT state machine interfaces
elx: libefc: Remote node state machine interfaces
elx: libefc: Fabric node state machine interfaces
elx: libefc: FC node ELS and state handling
elx: libefc: Extended link Service IO handling
elx: libefc: Register discovery objects with hardware
elx: efct: Data structures and defines for hw operations
elx: efct: Driver initialization routines
elx: efct: Hardware queues creation and deletion
elx: efct: RQ buffer, memory pool allocation and deallocation APIs
elx: efct: Hardware IO and SGL initialization
elx: efct: Hardware queues processing
elx: efct: Unsolicited FC frame processing routines
elx: efct: SCSI IO handling routines
elx: efct: LIO backend interface routines
elx: efct: Hardware IO submission routines
elx: efct: link and host statistics
elx: efct: xport and hardware teardown routines
elx: efct: scsi_transport_fc host interface support
elx: efct: Add Makefile and Kconfig for efct driver
elx: efct: Tie into kernel Kconfig and build process
MAINTAINERS | 9 +
drivers/scsi/Kconfig | 2 +
drivers/scsi/Makefile | 1 +
drivers/scsi/elx/Kconfig | 9 +
drivers/scsi/elx/Makefile | 18 +
drivers/scsi/elx/efct/efct_driver.c | 789 ++++
drivers/scsi/elx/efct/efct_driver.h | 109 +
drivers/scsi/elx/efct/efct_hw.c | 3636 +++++++++++++++++
drivers/scsi/elx/efct/efct_hw.h | 782 ++++
drivers/scsi/elx/efct/efct_hw_queues.c | 679 ++++
drivers/scsi/elx/efct/efct_io.c | 191 +
drivers/scsi/elx/efct/efct_io.h | 174 +
drivers/scsi/elx/efct/efct_lio.c | 1689 ++++++++
drivers/scsi/elx/efct/efct_lio.h | 189 +
drivers/scsi/elx/efct/efct_scsi.c | 1164 ++++++
drivers/scsi/elx/efct/efct_scsi.h | 207 +
drivers/scsi/elx/efct/efct_unsol.c | 493 +++
drivers/scsi/elx/efct/efct_unsol.h | 17 +
drivers/scsi/elx/efct/efct_xport.c | 1280 ++++++
drivers/scsi/elx/efct/efct_xport.h | 186 +
drivers/scsi/elx/include/efc_common.h | 41 +
drivers/scsi/elx/libefc/efc.h | 69 +
drivers/scsi/elx/libefc/efc_cmds.c | 855 ++++
drivers/scsi/elx/libefc/efc_cmds.h | 35 +
drivers/scsi/elx/libefc/efc_device.c | 1600 ++++++++
drivers/scsi/elx/libefc/efc_device.h | 72 +
drivers/scsi/elx/libefc/efc_domain.c | 1093 +++++
drivers/scsi/elx/libefc/efc_domain.h | 54 +
drivers/scsi/elx/libefc/efc_els.c | 1113 +++++
drivers/scsi/elx/libefc/efc_els.h | 107 +
drivers/scsi/elx/libefc/efc_fabric.c | 1565 +++++++
drivers/scsi/elx/libefc/efc_fabric.h | 116 +
drivers/scsi/elx/libefc/efc_node.c | 1102 +++++
drivers/scsi/elx/libefc/efc_node.h | 191 +
drivers/scsi/elx/libefc/efc_nport.c | 792 ++++
drivers/scsi/elx/libefc/efc_nport.h | 50 +
drivers/scsi/elx/libefc/efc_sm.c | 54 +
drivers/scsi/elx/libefc/efc_sm.h | 197 +
drivers/scsi/elx/libefc/efclib.c | 81 +
drivers/scsi/elx/libefc/efclib.h | 601 +++
drivers/scsi/elx/libefc_sli/sli4.c | 5169 ++++++++++++++++++++++++
drivers/scsi/elx/libefc_sli/sli4.h | 4115 +++++++++++++++++++
42 files changed, 30696 insertions(+)
create mode 100644 drivers/scsi/elx/Kconfig
create mode 100644 drivers/scsi/elx/Makefile
create mode 100644 drivers/scsi/elx/efct/efct_driver.c
create mode 100644 drivers/scsi/elx/efct/efct_driver.h
create mode 100644 drivers/scsi/elx/efct/efct_hw.c
create mode 100644 drivers/scsi/elx/efct/efct_hw.h
create mode 100644 drivers/scsi/elx/efct/efct_hw_queues.c
create mode 100644 drivers/scsi/elx/efct/efct_io.c
create mode 100644 drivers/scsi/elx/efct/efct_io.h
create mode 100644 drivers/scsi/elx/efct/efct_lio.c
create mode 100644 drivers/scsi/elx/efct/efct_lio.h
create mode 100644 drivers/scsi/elx/efct/efct_scsi.c
create mode 100644 drivers/scsi/elx/efct/efct_scsi.h
create mode 100644 drivers/scsi/elx/efct/efct_unsol.c
create mode 100644 drivers/scsi/elx/efct/efct_unsol.h
create mode 100644 drivers/scsi/elx/efct/efct_xport.c
create mode 100644 drivers/scsi/elx/efct/efct_xport.h
create mode 100644 drivers/scsi/elx/include/efc_common.h
create mode 100644 drivers/scsi/elx/libefc/efc.h
create mode 100644 drivers/scsi/elx/libefc/efc_cmds.c
create mode 100644 drivers/scsi/elx/libefc/efc_cmds.h
create mode 100644 drivers/scsi/elx/libefc/efc_device.c
create mode 100644 drivers/scsi/elx/libefc/efc_device.h
create mode 100644 drivers/scsi/elx/libefc/efc_domain.c
create mode 100644 drivers/scsi/elx/libefc/efc_domain.h
create mode 100644 drivers/scsi/elx/libefc/efc_els.c
create mode 100644 drivers/scsi/elx/libefc/efc_els.h
create mode 100644 drivers/scsi/elx/libefc/efc_fabric.c
create mode 100644 drivers/scsi/elx/libefc/efc_fabric.h
create mode 100644 drivers/scsi/elx/libefc/efc_node.c
create mode 100644 drivers/scsi/elx/libefc/efc_node.h
create mode 100644 drivers/scsi/elx/libefc/efc_nport.c
create mode 100644 drivers/scsi/elx/libefc/efc_nport.h
create mode 100644 drivers/scsi/elx/libefc/efc_sm.c
create mode 100644 drivers/scsi/elx/libefc/efc_sm.h
create mode 100644 drivers/scsi/elx/libefc/efclib.c
create mode 100644 drivers/scsi/elx/libefc/efclib.h
create mode 100644 drivers/scsi/elx/libefc_sli/sli4.c
create mode 100644 drivers/scsi/elx/libefc_sli/sli4.h
--
2.26.2
