On Sun, Jan 03, 2021 at 09:11:27AM -0800, James Smart wrote:
> This patch continues the efct driver population.
>
> This patch adds driver definitions for:
> Routines for SCSI transport IO alloc, build and send IO.
>
> Co-developed-by: Ram Vegesna <ram.vegesna@xxxxxxxxxxxx>
> Signed-off-by: Ram Vegesna <ram.vegesna@xxxxxxxxxxxx>
> Signed-off-by: James Smart <jsmart2021@xxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Just one nitpick. The rest looks good.
Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
> +struct efct_scsi_cmd_resp {
> + u8 scsi_status; /* SCSI status */
> + u16 scsi_status_qualifier; /* SCSI status qualifier */
> + /* pointer to response data buffer */
> + u8 *response_data;
> + /* length of response data buffer (bytes) */
> + u32 response_data_length;
> + u8 *sense_data; /* pointer to sense data buffer */
> + /* length of sense data buffer (bytes) */
> + u32 sense_data_length;
> + /* command residual (not used for target), positive value
> + * indicates an underflow, negative value indicates overflow
> + */
> + int residual;
> + /* Command response length received in wcqe */
> + u32 response_wire_length;
> +};
These comments should be in kernel doc format.
