On Tue, 2020-12-22 at 21:49 +0800, Ziqi Chen wrote: > As per specs, e.g, JESD220E chapter 7.2, while powering > off/on the ufs device, RST_N signal and REF_CLK signal > should be between VSS(Ground) and VCCQ/VCCQ2. > > To flexibly control device reset line, refactor the function > ufschd_vops_device_reset(sturct ufs_hba *hba) to ufshcd_ > vops_device_reset(sturct ufs_hba *hba, bool asserted). The > new parameter "bool asserted" is used to separate device reset > line pulling down from pulling up. > > Cc: Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> > Cc: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > Signed-off-by: Ziqi Chen <ziqichen@xxxxxxxxxxxxxx> Thanks for this fix including ufs-mediatek change as well. Reviewed-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> Tested-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>