On 12/21/20 10:24 PM, Nathan Chancellor wrote: > On Tue, Nov 17, 2020 at 12:50:31PM -0600, Tyrel Datwyler wrote: >> The vfcFrame correlation field is 64bit handle that is intended to trace >> I/O operations through both the client stack and VIOS stack when the >> underlying physical FC adapter supports tagging. >> >> Tag vfcFrames with the associated ibmvfc_event pointer handle. >> >> Signed-off-by: Tyrel Datwyler <tyreld@xxxxxxxxxxxxx> >> --- >> drivers/scsi/ibmvscsi/ibmvfc.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c >> index 0cab4b852b48..3922441a117d 100644 >> --- a/drivers/scsi/ibmvscsi/ibmvfc.c >> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c >> @@ -1693,6 +1693,8 @@ static int ibmvfc_queuecommand_lck(struct scsi_cmnd *cmnd, >> vfc_cmd->iu.pri_task_attr = IBMVFC_SIMPLE_TASK; >> } >> >> + vfc_cmd->correlation = cpu_to_be64(evt); >> + >> if (likely(!(rc = ibmvfc_map_sg_data(cmnd, evt, vfc_cmd, vhost->dev)))) >> return ibmvfc_send_event(evt, vhost, 0); >> >> @@ -2370,6 +2372,8 @@ static int ibmvfc_abort_task_set(struct scsi_device *sdev) >> tmf->iu.tmf_flags = IBMVFC_ABORT_TASK_SET; >> evt->sync_iu = &rsp_iu; >> >> + tmf->correlation = cpu_to_be64(evt); >> + >> init_completion(&evt->comp); >> rsp_rc = ibmvfc_send_event(evt, vhost, default_timeout); >> } >> -- >> 2.27.0 >> > > This patch introduces a clang warning, is this intentional behavior? Nope, I just missed the required cast. I've got a fixes patch queued up. I just haven't sent it yet. -Tyrel
