On Sat, Dec 19, 2020 at 12:30:39PM +0900, Daejun Park wrote: > @@ -323,6 +325,8 @@ static struct attribute *ufs_sysfs_device_descriptor[] = { > &dev_attr_number_of_secure_wpa.attr, > &dev_attr_psa_max_data_size.attr, > &dev_attr_psa_state_timeout.attr, > + &dev_attr_hpb_version.attr, > + &dev_attr_hpb_control.attr, > &dev_attr_ext_feature_sup.attr, > &dev_attr_wb_presv_us_en.attr, > &dev_attr_wb_type.attr, I thought I said this before, but you are adding new sysfs files, with no Documentation/ABI/ update which is not allowed. Please fix up. thanks, greg k-h