Re: [PATCH 3/3] libiscsi: fix iscsi_task use after free

[Mike Christie <michael.christie@xxxxxxxxxx>]

On 12/15/20 3:53 PM, Mike Christie wrote:
> @@ -1990,8 +1993,11 @@ enum blk_eh_timer_return iscsi_eh_cmd_timed_out(struct scsi_cmnd *sc)
>   		 * so let timeout code complete it now.
>   		 */
>   		rc = BLK_EH_DONE;
> +		spin_unlock(&session->back_lock);
>   		goto done;
>   	}
> +	__iscsi_get_task(task);
> +	spin_unlock(&session->back_lock);
>   
>   	if (session->state != ISCSI_STATE_LOGGED_IN) {
>   		/*

Just below this we loop over active tasks and access their scsi_cmnd,
so that will need to be fixed too. I'm going to send a new version
of this patchset.