Greg k-h,
> >
> > +static ssize_t wb_on_show(struct device *dev, struct
> > device_attribute *attr,
> > + char *buf)
> > +{
> > + struct ufs_hba *hba = dev_get_drvdata(dev);
> > +
> > + return scnprintf(buf, PAGE_SIZE, "%d\n", hba->wb_enabled);
>
> Please just use sysfs_emit().
thanks, will be changed in next version.
>
> > +}
> > +
> > +static ssize_t wb_on_store(struct device *dev, struct
> > device_attribute *attr,
> > + const char *buf, size_t count)
> > +{
> > + struct ufs_hba *hba = dev_get_drvdata(dev);
> > + unsigned int wb_enable;
> > + ssize_t res;
> > +
> > + if (ufshcd_is_clkscaling_supported(hba)) {
> > + /*
> > + * If the platform supports
> > UFSHCD_CAP_AUTO_BKOPS_SUSPEND,
> > + * turn WB on/off will be done while clock scaling
> > up/down.
> > + */
> > + dev_warn(dev, "To control WB through wb_on is not
> > allowed!\n");
> > + return -EOPNOTSUPP;
> > + }
> > + if (!ufshcd_is_wb_allowed(hba))
> > + return -EOPNOTSUPP;
> > +
> > + if (kstrtouint(buf, 0, &wb_enable))
> > + return -EINVAL;
> > +
> > + if (wb_enable != 0 && wb_enable != 1)
> > + return -EINVAL;
> > +
> > + pm_runtime_get_sync(hba->dev);
> > + res = ufshcd_wb_ctrl(hba, wb_enable);
> > + pm_runtime_put_sync(hba->dev);
> > +
> > + return res < 0 ? res : count;
> > +}
>
> Where is the new Documentation/ABI/ update for this new sysfs file
> you
> are adding?
>
It is missing, and will add it.
thanks.
Bean
