On Mon, 2020-12-14 at 08:46 -0800, Joe Perches wrote: > > However, we have other cases, the symbol and enum name are not the > > same, > > we can redefine EM/EMe, but there will introduce some redundant > > codes. > > This patch is to remove this restriction, let others reuse the > > current > > EM/EMe definition. > > I think the other way (adding new definitions for the cases when the > name and string are different) is less error prone. > yes, agree with you, but here it is ok, it is not too much copy/paste. > > diff --git a/include/trace/events/ufs.h > > b/include/trace/events/ufs.h > > [] > > +#define > > UFS_LINK_STATES \ > > + EM(UIC_LINK_OFF_STATE, "UIC_LINK_OFF_STATE") \ > > + EM(UIC_LINK_ACTIVE_STATE, "UIC_LINK_ACTIVE_STATE,") \ > > For instance: > > Like here where you added an unnecessary and unwanted comma Thanks, I will fix it in next version. Bean
