Mark Harvey wrote:
> Looking thru this driver, I saw what looks to be a bug/typo if an error
> occurs when
> calling driver_register() from scsi_debug_init()
>
> Cheers
> Mark
>
> --- scsi_debug-orig.c 2007-03-03 19:38:23.000000000 +1100
> +++ scsi_debug.c 2007-03-03 19:39:51.000000000 +1100
> @@ -2841,7 +2841,7 @@
> if (ret < 0) {
> printk(KERN_WARNING "scsi_debug: driver_register error:
> %d\n",
> ret);
> - goto bus_unreg;
> + goto driver_unreg;
> }
> ret = do_create_driverfs_files();
> if (ret < 0) {
> @@ -2873,6 +2873,7 @@
>
> del_files:
> do_remove_driverfs_files();
> +driver_unreg:
> driver_unregister(&sdebug_driverfs_driver);
> bus_unreg:
> bus_unregister(&pseudo_lld_bus);
Mark,
Um, I know my name is on that driver (with Eric's)
but I didn't write the code in that function.
I don't understand why your patch wants to call
driver_unregister() after driver_register() has failed.
Doug Gilbert
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
