On 03/12/2020 13:30, Kashyap Desai wrote:
-----Original Message-----
From: John Garry [mailto:john.garry@xxxxxxxxxx]
Sent: Thursday, December 3, 2020 6:57 PM
To: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>; linux-
scsi@xxxxxxxxxxxxxxx; linux-block@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v2 4/4] scsi: set shost as hctx driver_data
On 03/12/2020 03:41, Kashyap Desai wrote:
hctx->driver_data is not set for SCSI currently.
Separately set hctx->driver_data = shost.
nit: this looks ok to me, but I would have made as an earlier patch so
that you
don't add code and then remove it:
I added later - Just in case someone report issue in " scsi_commit_rqs" due
to this patch, we can revert back easily.
I tested scsi_mq_poll but not scsi_commit_rqs part.
We should be a bit more confident in the patch :)
anyway,
Reviewed-by: John Garry <john.garry@xxxxxxxxxx>
> static int scsi_mq_poll(struct blk_mq_hw_ctx *hctx)
> {
> - struct request_queue *q = hctx->queue;
> - struct scsi_device *sdev = q->queuedata;
> - struct Scsi_Host *shost = sdev->host;
Thanks,
John
