Re: [PATCH 27/34] esp_scsi: use host byte as last argument to esp_cmd_is_done()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Dec 2020, Hannes Reinecke wrote:

> Just pass in the host byte to esp_cmd_is_done(), and set the
> status or message bytes before calling this function.
> 

There are 3 such callsites but in 2 you've not done so.

Are you relying on the mid-layer to initialize the unset bytes to zero?

Wouldn't it be more readable to explicitly set the status and message 
bytes, as per the existing code?



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux