Re: [PATCH v2 2/4] megaraid_sas: iouring iopoll support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kashyap,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 0eedceafd3a63fd082743c914853ef4b9247dbe6]

url:    https://github.com/0day-ci/linux/commits/Kashyap-Desai/io_uring-iopoll-in-scsi-layer/20201203-194918
base:    0eedceafd3a63fd082743c914853ef4b9247dbe6
config: i386-randconfig-s001-20201203 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-179-ga00755aa-dirty
        # https://github.com/0day-ci/linux/commit/f2b4b005fc618696e1b343f91cf9907427e0df91
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kashyap-Desai/io_uring-iopoll-in-scsi-layer/20201203-194918
        git checkout f2b4b005fc618696e1b343f91cf9907427e0df91
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/scsi/megaraid/megaraid_sas_fusion.c:3652:5: warning: no previous prototype for 'megasas_blk_mq_poll' [-Wmissing-prototypes]
    3652 | int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
         |     ^~~~~~~~~~~~~~~~~~~

vim +/megasas_blk_mq_poll +3652 drivers/scsi/megaraid/megaraid_sas_fusion.c

  3651	
> 3652	int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
  3653	{
  3654	
  3655		struct megasas_instance *instance;
  3656		int num_entries = 0;
  3657		struct fusion_context *fusion;
  3658	
  3659		instance = (struct megasas_instance *)shost->hostdata;
  3660	
  3661		fusion = instance->ctrl_context;
  3662	
  3663		queue_num = queue_num + instance->low_latency_index_start;
  3664	
  3665		if (!atomic_add_unless(&fusion->busy_mq_poll[queue_num], 1, 1))
  3666			return 0;
  3667	
  3668		num_entries = complete_cmd_fusion(instance, queue_num, NULL);
  3669		atomic_dec(&fusion->busy_mq_poll[queue_num]);
  3670	
  3671		return num_entries;
  3672	}
  3673	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux