> > On Thu, 2020-12-03 at 07:27 +0000, Avri Altman wrote: > > > > > > From: Bean Huo <beanhuo@xxxxxxxxxx> > > > > > > Keep device power mode as active power mode and VCC supply only if > > > fWriteBoosterBufferFlushDuringHibernate setting 1 is successful. > > Hi Avri > Thanks so much taking time reiew. > > > Why would it fail? > > During the reliability testing in harsh environments, such as: > EMS testing, in the high/low-temperature environment. The system would > reboot itself, there will be programming failure very likely. > If we assume failure will never hit, why we capture its result > following with dev_err(). If you keep using your phone in a harsh > environment, you will see this print message. > > Of course, in a normal environment, the chance of failure likes you to > win a lottery, but the possibility still exists. Exactly. Hence we need-not any extra logic protecting device management command failures. if reading the configuration pass correctly, and UFSHCD_CAP_WB_EN is set, one should expect that any other functionality would work. Otherwise, any non-standard behavior should be added with a quirk. Thanks, Avri > > > > Since UFSHCD_CAP_WB_EN is toggled off on ufshcd_wb_probe If the > > device doesn't support wb, > > The check ufshcd_is_wb_allowed should suffice, isn't it? > > > > No, UFSHCD_CAP_WB_EN only tells us if the platform supports WB, > doesn't tell us fWriteBoosterBufferFlushDuringHibernate status. > > Thanks, > Bean >
