Hi Himanshu, > -----Original Message----- > From: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> > Sent: Tuesday, December 1, 2020 9:46 PM > To: Saurav Kashyap <skashyap@xxxxxxxxxxx> > Cc: Nilesh Javali <njavali@xxxxxxxxxxx>; Martin K . Petersen > <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic- > Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH 02/15] qla2xxx: Change post del message from > debug level to log level > > External Email > > ---------------------------------------------------------------------- > > > > On Dec 1, 2020, at 10:05 AM, Saurav Kashyap <skashyap@xxxxxxxxxxx> > wrote: > > > > Hi Himasnhu, > > Comments inline > > > >> -----Original Message----- > >> From: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> > >> Sent: Tuesday, December 1, 2020 9:15 PM > >> To: Nilesh Javali <njavali@xxxxxxxxxxx> > >> Cc: Martin K . Petersen <martin.petersen@xxxxxxxxxx>; linux- > >> scsi@xxxxxxxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic-Storage- > >> Upstream@xxxxxxxxxxx> > >> Subject: Re: [PATCH 02/15] qla2xxx: Change post del message from debug > level > >> to log level > >> > >> > >> > >>> On Dec 1, 2020, at 2:27 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote: > >>> > >>> From: Saurav Kashyap <skashyap@xxxxxxxxxxx> > >>> > >>> Change the message debug level. > >>> > >>> Signed-off-by: Saurav Kashyap <skashyap@xxxxxxxxxxx> > >>> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx> > >>> --- > >>> drivers/scsi/qla2xxx/qla_gs.c | 8 ++++---- > >>> 1 file changed, 4 insertions(+), 4 deletions(-) > >>> > >>> diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c > >>> index e28c4b7ec55f..391ac75e3de3 100644 > >>> --- a/drivers/scsi/qla2xxx/qla_gs.c > >>> +++ b/drivers/scsi/qla2xxx/qla_gs.c > >>> @@ -3558,10 +3558,10 @@ void > qla24xx_async_gnnft_done(scsi_qla_host_t > >> *vha, srb_t *sp) > >>> if (fcport->flags & FCF_FCP2_DEVICE) > >>> fcport->logout_on_delete = 0; > >>> > >>> - ql_dbg(ql_dbg_disc, vha, 0x20f0, > >>> - "%s %d %8phC post del sess\n", > >>> - __func__, __LINE__, > >>> - fcport->port_name); > >>> + ql_log(ql_log_warn, vha, 0x20f0, > >>> + "%s %d %8phC post del sess\n", > >>> + __func__, __LINE__, > >>> + fcport->port_name); > >>> > >>> > >> qlt_schedule_sess_for_deletion(fcport); > >>> continue; > >>> -- > >>> 2.19.0.rc0 > >>> > >> > >> I am okay with the change just curious, Would it not flood message file for > >> large number of sessions? > > > > This was added mainly for help in debugging, if debug is not enabled. > Sometimes we get logs > > where it's hard to tell what happened to particular session. Moreover session > deletion is not > > very common scenario. > > > > In that case, I would also prefer to see message coming out from > qlt_schedule_sess_for_deletion(), because that’s where you can track that > session is scheduled for deletion. > > I would prefer this message also changed to ql_log_warn. > > ql_dbg(ql_dbg_disc, sess->vha, 0xe001, > "Scheduling sess %p for deletion %8phC\n", > sess, sess->port_name); Make sense, will update it in next version. Thanks, ~Saurav > > > Thanks, > > ~Saurav > >> > >> -- > >> Himanshu Madhani Oracle Linux Engineering > > > > -- > Himanshu Madhani Oracle Linux Engineering
