> On Dec 1, 2020, at 2:27 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
>
> From: Saurav Kashyap <skashyap@xxxxxxxxxxx>
>
> Driver unload with IOs causes server to crash.
> Return IO with retry if fcport undergoing deletion.
>
Any call stack or panic signature to share in commit message?
> Signed-off-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index a75edba2b334..be9d10092dd3 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -884,8 +884,8 @@ qla2xxx_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
> goto qc24_fail_command;
> }
>
> - if (!fcport) {
> - cmd->result = DID_NO_CONNECT << 16;
> + if (!fcport || fcport->deleted) {
> + cmd->result = DID_IMM_RETRY << 16;
> goto qc24_fail_command;
> }
>
> @@ -966,8 +966,8 @@ qla2xxx_mqueuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd,
> goto qc24_fail_command;
> }
>
> - if (!fcport) {
> - cmd->result = DID_NO_CONNECT << 16;
> + if (!fcport || fcport->deleted) {
> + cmd->result = DID_IMM_RETRY << 16;
> goto qc24_fail_command;
> }
>
> --
> 2.19.0.rc0
>
Patch itself looks good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
