Re: [PATCH 10/15] qla2xxx: Handle aborts correctly for port undergoing deletion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Dec 1, 2020, at 2:27 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
> 
> From: Saurav Kashyap <skashyap@xxxxxxxxxxx>
> 
> Call trace observed while shutting down the adapter ports (LINK DOWN).
> Handle aborts correctly.
> 

Could you post call trace in commit message. 

> Signed-off-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index d4159d5a4ffd..eab559b3b257 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -227,7 +227,7 @@ static void qla_nvme_abort_work(struct work_struct *work)
> 	       "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n",
> 	       __func__, sp, sp->handle, fcport, fcport->deleted);
> 
> -	if (!ha->flags.fw_started && fcport->deleted)
> +	if (!ha->flags.fw_started || fcport->deleted)
> 		goto out;
> 
> 	if (ha->flags.host_shutting_down) {
> -- 
> 2.19.0.rc0
> 

Change itself is fine. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux