> On Dec 1, 2020, at 2:27 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
>
> From: Arun Easi <aeasi@xxxxxxxxxxx>
>
> Some fields are not correctly byte swapped causing failure
> during initialization. As probe() returns failure, HBAs
> will not be claimed when this happens.
>
> Signed-off-by: Arun Easi <aeasi@xxxxxxxxxxx>
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
I think this patch needs following fixes tag
Fixes: 9f2475fe7406b ("scsi: qla2xxx: SAN congestion management implementation")
Fixes: cf3c54fb49a4e ("scsi: qla2xxx: Add SLER and PI control support”)
> ---
> drivers/scsi/qla2xxx/qla_mbx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index 40af7f1524ce..1b4261c3c476 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -1129,7 +1129,7 @@ qla2x00_get_fw_version(scsi_qla_host_t *vha)
> if (ha->flags.scm_supported_a &&
> (ha->fw_attributes_ext[0] & FW_ATTR_EXT0_SCM_SUPPORTED)) {
> ha->flags.scm_supported_f = 1;
> - ha->sf_init_cb->flags |= BIT_13;
> + ha->sf_init_cb->flags |= cpu_to_le16(BIT_13);
> }
> ql_log(ql_log_info, vha, 0x11a3, "SCM in FW: %s\n",
> (ha->flags.scm_supported_f) ? "Supported" :
> @@ -1137,9 +1137,9 @@ qla2x00_get_fw_version(scsi_qla_host_t *vha)
>
> if (vha->flags.nvme2_enabled) {
> /* set BIT_15 of special feature control block for SLER */
> - ha->sf_init_cb->flags |= BIT_15;
> + ha->sf_init_cb->flags |= cpu_to_le16(BIT_15);
> /* set BIT_14 of special feature control block for PI CTRL*/
> - ha->sf_init_cb->flags |= BIT_14;
> + ha->sf_init_cb->flags |= cpu_to_le16(BIT_14);
> }
> }
>
> --
> 2.19.0.rc0
>
Otherwise, Looks good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
