On 11/30/20 1:17 AM, Daniel Wagner wrote: > Hi Tom, > > On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@xxxxxxxxxx wrote: >> From: Tom Rix <trix@xxxxxxxxxx> >> >> The macro use will already have a semicolon. >> >> Signed-off-by: Tom Rix <trix@xxxxxxxxxx> > Reviewed-by: Daniel Wagner <dwagner@xxxxxxx> > >> --- >> drivers/scsi/qla2xxx/qla_def.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h >> index ed9b10f8537d..86d249551b2d 100644 >> --- a/drivers/scsi/qla2xxx/qla_def.h >> +++ b/drivers/scsi/qla2xxx/qla_def.h >> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk { >> } while (0) >> >> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \ >> - atomic_dec(&__qpair->ref_count); \ >> + atomic_dec(&__qpair->ref_count) \ > Nitpick, please insert an additional tab after the remove so that the > backlashes align again. How about removing the last escaped newline and the next empty line ? Tom > > Thanks, > Daniel >