On Thu, Nov 26, 2020 at 02:29:48PM +0100, Sebastian Andrzej Siewior wrote: > From: "Ahmed S. Darwish" <a.darwish@xxxxxxxxxxxxx> > > The in_interrupt() macro is ill-defined and does not provide what the > name suggests. The usage especially in driver code is deprecated and a > tree-wide effort to clean up and consolidate the (ab)usage of > in_interrupt() and related checks is happening. > > In this case the check covers only parts of the contexts in which these > functions cannot be called. It fails to detect preemption or interrupt > disabled invocations. > > As wait_for_completion() already contains a broad variety of checks > (always enabled or debug option dependent) which cover all invalid > conditions already, there is no point in having extra inconsistent > warnings in drivers. > > Just remove it. > > Signed-off-by: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxxxxx> Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
