On Thu, Nov 26, 2020 at 02:29:43PM +0100, Sebastian Andrzej Siewior wrote: > From: "Ahmed S. Darwish" <a.darwish@xxxxxxxxxxxxx> > > tcm_qla2xxx_free_session() has a BUG_ON(in_interrupt()). > > While in_interrupt() is ill-defined and does not provide what the name > suggests, it is not needed here: the function is always invoked from > workqueue context through "struct qla_tgt_func_tmpl" ->free_session() > hook it is bound to. > > The function also calls wait_event_timeout() down the chain, which > already has a might_sleep(). > > Remove the in_interrupt() check. > > Signed-off-by: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Cc: Nilesh Javali <njavali@xxxxxxxxxxx> > Cc: <GR-QLogic-Storage-Upstream@xxxxxxxxxxx> Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
