RE: [PATCH v1 2/3] megaraid_sas: iouring iopoll support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: John Garry [mailto:john.garry@xxxxxxxxxx]
> Sent: Friday, November 20, 2020 2:03 PM
> To: Hannes Reinecke <hare@xxxxxxx>; Kashyap Desai
> <kashyap.desai@xxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx
> Cc: sumit.saxena@xxxxxxxxxxxx; chandrakanth.patil@xxxxxxxxxxxx;
> linux-block@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 2/3] megaraid_sas: iouring iopoll support
>
> On 20/11/2020 07:14, Hannes Reinecke wrote:
> >>
> >>       struct rdpq_alloc_detail rdpq_tracker[RDPQ_MAX_CHUNK_COUNT];
> >>
> > The usage of atomic_add_unless() is a bit unusual; one might consider
> > using atomic_test_and_set(). Also it seems to be a bit of a waste
> > using an atomic counter here, seeing that the only values ever used
> > are 0 and 1. But this is largely cosmetic, so:
>
> atomic_add_unless() is generally implemented with a cmpxchg(), which can
> be inefficient also.


John -

Noted. I was able to get expected performance on multiple host using
atomic_add_() API.
We can improve based on any real time issue.  Is it fine ?

@Hannes - I will add Reviewed-by Tag in V2 series.

>
> John

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux