On 2020-11-24 17:38, John Garry wrote:
Hi Marc,
So initially in the msi_prepare method we setup the its dev - this is
from the mbigen probe. Then when all the irqs are unmapped later for
end device driver removal, we release this its device in
its_irq_domain_free(). But I don't see anything to set it up again.
Is
it improper to have released the its device in this scenario?
Commenting out the release makes things "good" again.
Huh, that's ugly. The issue is that the device that deals with the
interrupts isn't the device that the ITS knows about (there isn't a
1:1 mapping between mbigen and the endpoint).
The mbigen is responsible for the creation of the corresponding
irqdomain, and and crucially for the "prepare" phase, which results
in storing the its_dev pointer in info->scratchpad[0].
As we free all the interrupts associated with the endpoint, we
free the its_dev (nothing else needs it at this point). On the
next allocation, we reuse the damn its_dev pointer, and we're SOL.
This is wrong, because we haven't removed the mbigen, only the
device *connected* to the mbigen. And since the mbigen can be shared
across endpoints, we can't reliably tear it down at all. Boo.
The only thing to do is to convey that by marking the its_dev as
shared so that it isn't deleted when no LPIs are being used. After
all, it isn't like the mbigen is going anywhere.
Right, I did consider this.
FWIW, I've pushed my hack branch[1] out with a couple of patches
for you to try (the top 3 patches). They allow platform-MSI domains
created by devices (mbigen, ICU) to be advertised as shared between
devices, so that the low-level driver can handle that in an appropriate
way.
I gave it a go on my D05 and nothing blew up, but I can't really remove
the kernel module, as that's where my disks are... :-/
Please let me know if that helps.
It is just that passing that information down isn't a simple affair,
as msi_alloc_info_t isn't a generic type... Let me have a think.
I think that there is a way to circumvent the problem, which you might
call hacky, but OTOH, not sure if there's much point changing mbigen
or related infrastructure at this stage.
Bah, it's a simple change, and there is now more than the mbigen using
the same API...
Anyway, so we have 128 irqs in total for the mbigen domain, but the
driver only is interesting in something like irq indexes 1,2,72-81,
and 96-112. So we can just dispose the mappings for irq index 0-112 at
removal stage, thereby keeping the its device around. We do still call
platform_irq_count(), which sets up all 128 mappings, so maybe we
should be unmapping all of these - this would be the contentious part.
But maybe not, as the device driver is only interested in that subset,
and has no business unmapping the rest.
I don't think the driver should mess with interrupts it doesn't own.
And while the mbigen port that is connected to the SAS controller
doesn't seem to be shared between endpoints, some other ports definitely
are:
# cat /sys/kernel/debug/irq/domains/\\_SB.MBI1
name: \_SB.MBI1
size: 409
mapped: 192
flags: 0x00000003
[...]
I guess that the other 217 lines are connected somewhere.
With that change, the platform.c API would work a bit more like the
pci msi code equivalent, where we request a min and max number of
vectors. In fact, that platform.c change needs to be made anyway as
platform_get_irqs_affinity() is broken currently for when nr_cpus <
#hw queues.
Thoughts?
I'm happy to look at some code! ;-)
M.
--
Jazz is not dead. It just smells funny...
