On Mon, 2020-11-16 at 09:23 +0100, Hannes Reinecke wrote:
> On 11/11/20 5:58 AM, Muneendra wrote:
> > Added support to handle eh_should_retry_cmd in lpfc_template.
> >
> > Signed-off-by: Muneendra <muneendra.kumar@xxxxxxxxxxxx>
> >
> > ---
> > v7:
> > New patch
> > ---
> > drivers/scsi/lpfc/lpfc_scsi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/lpfc/lpfc_scsi.c
> > b/drivers/scsi/lpfc/lpfc_scsi.c
> > index 4ffdfd2c8604..dbc80e6423ea 100644
> > --- a/drivers/scsi/lpfc/lpfc_scsi.c
> > +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> > @@ -6040,6 +6040,7 @@ struct scsi_host_template lpfc_template = {
> > .info = lpfc_info,
> > .queuecommand = lpfc_queuecommand,
> > .eh_timed_out = fc_eh_timed_out,
> > + .eh_should_retry_cmd = fc_eh_should_retry_cmd,
> > .eh_abort_handler = lpfc_abort_handler,
> > .eh_device_reset_handler = lpfc_device_reset_handler,
> > .eh_target_reset_handler = lpfc_target_reset_handler,
> >
>
> I guess this change is pretty generic, and should be made to every
> FC
> HBA driver. But probably not your immediate scope, I do agree :-)
Yes, I think this is better left to the other driver maintainers
as it should be tested if it is called via the host template.
-Ewan
>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
>
> Cheers,
>
> Hannes
